New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Theming: Show loading spinner while uploading files #1186

Merged
merged 1 commit into from Aug 30, 2016

Conversation

Projects
None yet
5 participants
@juliushaertl
Member

juliushaertl commented Aug 30, 2016

backport of #1178

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 30, 2016

@juliushaertl, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jancborchardt, @schiessle and @LukasReschke to be potential reviewers

mention-bot commented Aug 30, 2016

@juliushaertl, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jancborchardt, @schiessle and @LukasReschke to be potential reviewers

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Aug 30, 2016

Member

Tested and works 👍

Member

MorrisJobke commented Aug 30, 2016

Tested and works 👍

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke
Member

MorrisJobke commented Aug 30, 2016

@rullzer

This comment has been minimized.

Show comment
Hide comment
@rullzer

rullzer Aug 30, 2016

Member

LGTM

Member

rullzer commented Aug 30, 2016

LGTM

@rullzer rullzer merged commit a2a17fc into stable10 Aug 30, 2016

4 checks passed

Scrutinizer 7 new issues
Details
approvals/lgtm this commit looks good
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rullzer rullzer deleted the stable10-backport1178 branch Aug 30, 2016

@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt
Member

jancborchardt commented Aug 31, 2016

Thank you @juliushaertl! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment