New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vendor name in PHP version warning #1209

Merged
merged 1 commit into from Aug 31, 2016

Conversation

Projects
None yet
5 participants
@nickvergessen
Member

nickvergessen commented Aug 31, 2016

Only missing on stable10

@LukasReschke @MorrisJobke

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 31, 2016

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @butonic and @DeepDiver1975 to be potential reviewers

mention-bot commented Aug 31, 2016

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @butonic and @DeepDiver1975 to be potential reviewers

@rullzer

This comment has been minimized.

Show comment
Hide comment
@rullzer

rullzer Aug 31, 2016

Member

👍

Member

rullzer commented Aug 31, 2016

👍

1 similar comment
@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke
Member

MorrisJobke commented Aug 31, 2016

👍

@rullzer rullzer merged commit 50f40d9 into stable10 Aug 31, 2016

4 checks passed

Scrutinizer No new issues
Details
approvals/lgtm this commit looks good
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rullzer rullzer deleted the fix-vendor-in-php-warning branch Aug 31, 2016

@marinofaggiana

This comment has been minimized.

Show comment
Hide comment
@marinofaggiana

marinofaggiana Sep 30, 2016

Member

I would understand if some external API reports Nextcloud or ownCloud ?

Member

marinofaggiana commented Sep 30, 2016

I would understand if some external API reports Nextcloud or ownCloud ?

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Sep 30, 2016

Member

I would understand if some external API reports Nextcloud or ownCloud ?

/status.php will report with Nextcloud 11+ the product name:

{"installed":true,"maintenance":false,"version":"9.2.0.3","versionstring":"11.0 alpha","edition":"","productname":"Nextcloud"}
Member

MorrisJobke commented Sep 30, 2016

I would understand if some external API reports Nextcloud or ownCloud ?

/status.php will report with Nextcloud 11+ the product name:

{"installed":true,"maintenance":false,"version":"9.2.0.3","versionstring":"11.0 alpha","edition":"","productname":"Nextcloud"}
@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke
Member

MorrisJobke commented Sep 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment