New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable14] Bring the browser window of an actor to the foreground when acting as him #12120

Merged
merged 1 commit into from Oct 29, 2018

Conversation

Projects
None yet
3 participants
@danxuliu
Member

danxuliu commented Oct 29, 2018

Backport of #12063

Move the browser window of an actor to the foreground when acting as him
Each time a new actor appears in a scenario the browser window of the
new actor is put in front of the browser windows of the previous actors.
Before, when acting again as a previous actor his browser window stayed
in the background; in most cases everything worked fine even if the
window was in the background, but due to a bug in the Firefox driver of
Selenium and/or maybe in Firefox itself when the window was in the
background it was not possible to set the value of an input field that
had a range selected.

Now, when acting again as a previous actor his browser window is brought
to the foreground. This prevents the bug from manifesting, but also
reflects better how a user would interact with the browser in real life.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

@danxuliu danxuliu added this to the Nextcloud 14.0.4 milestone Oct 29, 2018

@danxuliu danxuliu requested review from rullzer and MorrisJobke Oct 29, 2018

@rullzer rullzer merged commit 8971f7d into stable14 Oct 29, 2018

1 check passed

continuous-integration/drone/pr the build was successful
Details

@rullzer rullzer deleted the stable14-12063-bring-the-browser-window-of-an-actor-to-the-foreground-when-acting-as-him branch Oct 29, 2018

@MorrisJobke MorrisJobke referenced this pull request Nov 13, 2018

Merged

14.0.4 RC 1 #12436

@MorrisJobke MorrisJobke referenced this pull request Nov 22, 2018

Merged

14.0.4 #12586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment