New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable14] Do not set indeterminate state for file shares #12187

Merged
merged 2 commits into from Nov 1, 2018

Conversation

@juliushaertl
Member

juliushaertl commented Nov 1, 2018

Files just have one edit permission checkbox, so having an indeterminate state there doesn't make sense and actually broke updating the edit permission on file shares.

backport of #12163

juliushaertl added some commits Oct 31, 2018

Do not set indeterminate state for file shares
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Add tests for edit permission state on file shares
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@danxuliu

Removing reshare permissions in a file also removes edit permissions; I do not know if that is a different issue or is related to this pull request.

@MorrisJobke

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 5bb7378 into stable14 Nov 1, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the stable14-12163 branch Nov 1, 2018

@MorrisJobke MorrisJobke referenced this pull request Nov 13, 2018

Merged

14.0.4 RC 1 #12436

@MorrisJobke MorrisJobke referenced this pull request Nov 22, 2018

Merged

14.0.4 #12586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment