Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable14] Do not set indeterminate state for file shares #12187

Merged
merged 2 commits into from Nov 1, 2018

Conversation

@juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Nov 1, 2018

Files just have one edit permission checkbox, so having an indeterminate state there doesn't make sense and actually broke updating the edit permission on file shares.

backport of #12163

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Copy link
Member

@danxuliu danxuliu left a comment

Removing reshare permissions in a file also removes edit permissions; I do not know if that is a different issue or is related to this pull request.

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 5bb7378 into stable14 Nov 1, 2018
1 check failed
1 check failed
continuous-integration/drone/pr the build failed
Details
@MorrisJobke MorrisJobke deleted the stable14-12163 branch Nov 1, 2018
@MorrisJobke MorrisJobke mentioned this pull request Nov 13, 2018
@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants