Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid logging of "Partial search results returned: Sizelimit exceeded…" #12292

Merged
merged 1 commit into from Nov 15, 2018

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Nov 5, 2018

When a search request containing a limit is sent against an LDAP server, most will sent the message as in $subject along with the results. The LDAP PHP module triggers this as an PHP error, thus ending up through our error handler in the Nextcloud log.

While not being an error in itself, often admins perceive this as confusing, ending up in several requests not only in this issue tracker. Hence, it would be nice to filter out this message, like this PR does. Fixes #2947

An alternative approach would be to open up our internal error handler from core to app specific proceedings.

How to test:

  1. It works with a new as well as existing LDAP config
  2. Go to the LDAP wizard
  3. Watch the Nextcloud log
  4. Open the "Login attributes" tab

Before the patch, the mentioned error message would be written. Now it is not supposed to happen anymore.

… at"

LDAP servers respond with that even if a limit was passed with the
request. Having this statement logged causes a lot of confusion.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the fix/2947/lapse-sizelimit-error branch from 931946f to deec5a7 Nov 7, 2018
@MorrisJobke MorrisJobke mentioned this pull request Nov 8, 2018
16 of 24 tasks complete
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Tested and works 👍

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Nov 15, 2018

@rullzer Mind to review this one?

Copy link
Member

@rullzer rullzer left a comment

🐘

@MorrisJobke MorrisJobke merged commit 159d759 into master Nov 15, 2018
1 check failed
1 check failed
continuous-integration/drone/pr the build failed
Details
@MorrisJobke MorrisJobke deleted the fix/2947/lapse-sizelimit-error branch Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants