New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14] Use the proper server for the apptoken flow login #12299

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
3 participants
@rullzer
Member

rullzer commented Nov 6, 2018

Backport of #12177

Use the proper server for the apptoken flow login
If a user can't authenticate normally (because they have 2FA that is not
available on their devices for example). The redirect that is generated
should be of the proper format.

This means

1. Include the protocol
2. Include the possible subfolder

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

@rullzer rullzer added the 3. to review label Nov 6, 2018

@rullzer rullzer added this to the Nextcloud 14.0.4 milestone Nov 6, 2018

@rullzer rullzer requested review from MorrisJobke and ChristophWurst Nov 6, 2018

@MorrisJobke

Makes sense 👍

@MorrisJobke MorrisJobke merged commit e10b7c8 into stable14 Nov 6, 2018

1 check passed

continuous-integration/drone/pr the build was successful
Details

@MorrisJobke MorrisJobke deleted the backport/12177/stable14 branch Nov 6, 2018

@MorrisJobke MorrisJobke referenced this pull request Nov 13, 2018

Merged

14.0.4 RC 1 #12436

@MorrisJobke MorrisJobke referenced this pull request Nov 22, 2018

Merged

14.0.4 #12586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment