New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14] Do not log FileLock as exception #12300

Merged
merged 2 commits into from Nov 6, 2018

Conversation

Projects
None yet
3 participants
@rullzer
Member

rullzer commented Nov 6, 2018

Backport of #12230

rullzer added some commits Nov 2, 2018

Do not log FileLock as exception
There is no reason to log FileLock errors as exceptions to the log file.
Locks happen for very legit reasons and it is actually a sign of the
code doing its job.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Fix tests
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

@rullzer rullzer added the 3. to review label Nov 6, 2018

@rullzer rullzer added this to the Nextcloud 14.0.4 milestone Nov 6, 2018

@rullzer rullzer requested review from MorrisJobke and icewind1991 Nov 6, 2018

@MorrisJobke

👍

@MorrisJobke MorrisJobke merged commit 8a86f59 into stable14 Nov 6, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the backport/12230/stable14 branch Nov 6, 2018

@MorrisJobke MorrisJobke referenced this pull request Nov 13, 2018

Merged

14.0.4 RC 1 #12436

@MorrisJobke MorrisJobke referenced this pull request Nov 22, 2018

Merged

14.0.4 #12586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment