New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14] Set the filemodel before rending the detailsview #12301

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
3 participants
@rullzer
Member

rullzer commented Nov 6, 2018

Backport #12231

Set the filemodel before rending the detailsview
fixes #10934

Else it triggers the rendering two times. Resulting is weird state in
for example the comments. Because the comments for OLD_FILEID are
retrieved but then the model is changed to NEW_FILEID. But the old
comments still get in and get parsed.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

@rullzer rullzer added the 3. to review label Nov 6, 2018

@rullzer rullzer added this to the Nextcloud 14.0.4 milestone Nov 6, 2018

@rullzer rullzer changed the title from Set the filemodel before rending the detailsview to [14] Set the filemodel before rending the detailsview Nov 6, 2018

@rullzer rullzer added 4. to release and removed 3. to review labels Nov 6, 2018

@rullzer rullzer merged commit 524a344 into stable14 Nov 6, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@rullzer rullzer deleted the backport/12231/stable14 branch Nov 6, 2018

@MorrisJobke MorrisJobke referenced this pull request Nov 13, 2018

Merged

14.0.4 RC 1 #12436

@MorrisJobke MorrisJobke referenced this pull request Nov 22, 2018

Merged

14.0.4 #12586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment