Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sorting in file picker #12350

Merged
merged 3 commits into from Nov 20, 2018
Merged

Enable sorting in file picker #12350

merged 3 commits into from Nov 20, 2018

Conversation

@juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Nov 8, 2018

Fixes #645

This allows sorting the entries in the file picker by name, size or mtime.

List view:
image

Grid view:
image

Copy link
Member

@skjnldsv skjnldsv left a comment

Working fine here!

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Nov 13, 2018

  • header also shown in the empty file list
    bildschirmfoto 2018-11-13 um 16 27 47
  • loading spinner is placed over the header
    bildschirmfoto 2018-11-13 um 16 27 52
@MorrisJobke MorrisJobke added this to the Nextcloud 15 milestone Nov 13, 2018
@MorrisJobke MorrisJobke mentioned this pull request Nov 13, 2018
16 of 24 tasks complete
@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Nov 14, 2018

@juliushaertl Moved to 16, but we maybe want to back port this anyways, right?

@rullzer
Copy link
Member

@rullzer rullzer commented Nov 14, 2018

@MorrisJobke yes that is right

juliushaertl added 3 commits Nov 8, 2018
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl force-pushed the filepicker-sorting branch from aec9506 to 5e5cced Nov 16, 2018
@juliushaertl
Copy link
Member Author

@juliushaertl juliushaertl commented Nov 16, 2018

@MorrisJobke Fixed.

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Tested and works 👍

@MorrisJobke MorrisJobke merged commit a9de88e into master Nov 20, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/drone/pr the build failed
Details
@dco
DCO DCO
Details
@fixupbot
fixupbot Fixup
Details
@MorrisJobke MorrisJobke deleted the filepicker-sorting branch Nov 20, 2018
@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Nov 20, 2018

/backport to stable14

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Nov 20, 2018

/backport to stable13

@rullzer
Copy link
Member

@rullzer rullzer commented Nov 20, 2018

The backport failed in a way the bot did not handle it properly. I'll look into that

@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
7 of 7 tasks complete
@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Nov 22, 2018

/backport to stable14

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Nov 22, 2018

The backport to stable13 failed. Please do this backport manually.

@juliushaertl
Copy link
Member Author

@juliushaertl juliushaertl commented Nov 29, 2018

We'll not backport this for now as discussed with @MorrisJobke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants