/server

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14] Properly search the root of a shared external storage #12375

Merged
merged 1 commit into from Nov 13, 2018
+1 −1

Conversation

Reviewers

@MorrisJobke MorrisJobke

@JanDragon JanDragon

@icewind1991 icewind1991

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
  Nextcloud 14.0.4
3 participants
@rullzer @MorrisJobke @JanDragon
@rullzer
Member

rullzer commented Nov 9, 2018

Backport of #12284
@rullzer
Properly search the root of a shared external storage 
Fixes #1020

When an external storage is shared with you in full the root is ''
(empty). This adds an extra check for an empty jail basically.

Because if the jail is on the empty string. It matches all paths.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Verified
This commit was signed with a verified signature.
@rullzer rullzer Roeland Jago Douma
GPG key ID: F941078878347C0C Learn about signing commits
Loading status checks…
b71bc12

@rullzer rullzer added the 3. to review label Nov 9, 2018

@rullzer rullzer added this to the Nextcloud 14.0.4 milestone Nov 9, 2018

@rullzer rullzer requested review from MorrisJobke and icewind1991 Nov 9, 2018

@MorrisJobke

MorrisJobke approved these changes Nov 12, 2018
View changes

@MorrisJobke MorrisJobke referenced this pull request Nov 13, 2018

Merged

14.0.4 RC 1 #12436

@JanDragon

JanDragon approved these changes Nov 13, 2018
View changes

@MorrisJobke MorrisJobke merged commit db9e1b9 into stable14 Nov 13, 2018
1 check failed

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the backport/12284/stable14 branch Nov 13, 2018

@MorrisJobke MorrisJobke referenced this pull request Nov 22, 2018

Merged

14.0.4 #12586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment