Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14] Properly search the root of a shared external storage #12375

Merged
merged 1 commit into from Nov 13, 2018

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Nov 9, 2018

Backport of #12284

Fixes #1020

When an external storage is shared with you in full the root is ''
(empty). This adds an extra check for an empty jail basically.

Because if the jail is on the empty string. It matches all paths.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added the 3. to review label Nov 9, 2018
@rullzer rullzer added this to the Nextcloud 14.0.4 milestone Nov 9, 2018
@rullzer rullzer requested review from MorrisJobke and icewind1991 Nov 9, 2018
@MorrisJobke MorrisJobke mentioned this pull request Nov 13, 2018
@MorrisJobke MorrisJobke merged commit db9e1b9 into stable14 Nov 13, 2018
1 check failed
1 check failed
continuous-integration/drone/pr the build failed
Details
@MorrisJobke MorrisJobke deleted the backport/12284/stable14 branch Nov 13, 2018
@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants