New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the warning appearing in the admin section when mail_smtpmode is not configured #12401

Merged
merged 3 commits into from Nov 19, 2018

Conversation

@pachulo
Copy link
Contributor

pachulo commented Nov 11, 2018

Closes #11107

The bug is preventing the snap stable channel to jump to 14:

So if this is OK it should be backported to 14.

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented Nov 11, 2018

Thanks for doing this, @pachulo. Would you mind also adding a test for this to tests/Settings/Controller/CheckSetupControllerTest.php?

@pachulo

This comment has been minimized.

Copy link
Contributor

pachulo commented Nov 11, 2018

Honestly, I'm not really sure how to that...any tips or examples?
By the way, shouldn't be sufficient with what was implemented here? 6a0c54d#diff-685bc48aa08f64600f193f0584663365

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented Nov 14, 2018

Honestly, I'm not really sure how to that...any tips or examples?
By the way, shouldn't be sufficient with what was implemented here? [...]

No, that's just mocking stuff out, it'll pass regardless of the change done here. Sadly, the heavy mocks and private implementation make this hard to test; I suspect the best we can achieve is what I just pushed (hope you don't mind).

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented Nov 14, 2018

By the way, looks like CI wants you to sign off on your commits:

Some commits were not signed off!
Missing signatures on:

Verify that isPhpMailerUsed uses config as expected
Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>

@skjnldsv skjnldsv requested review from rullzer , nickvergessen and MorrisJobke Nov 16, 2018

@skjnldsv skjnldsv added this to the Nextcloud 15 milestone Nov 16, 2018

@fishscene

This comment has been minimized.

Copy link

fishscene commented Nov 17, 2018

I'm a bit new to Github terminology, but does adding this to the Nextcloud 15 milestone mean we won't be seeing this for Nextcloud 14.x?

@danielkesselberg

This comment has been minimized.

Copy link
Contributor

danielkesselberg commented Nov 17, 2018

Depends. Every new feature/bugfix is developed for the next release (15 right now). Sometimes bugfixes are "backported" for older version.

Use the proper default values
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
Copy link
Member

MorrisJobke left a comment

Tested and works 👍

@danielkesselberg
Copy link
Contributor

danielkesselberg left a comment

👍

@skjnldsv skjnldsv added 4. to release and removed 3. to review labels Nov 19, 2018

@MorrisJobke MorrisJobke merged commit 5af6289 into nextcloud:master Nov 19, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Nov 19, 2018

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Nov 19, 2018

This was introduced to 14.0.2: 0dd4a3e

Let's back port this one here.

@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Nov 19, 2018

Backport is in #12529

@pachulo pachulo deleted the pachulo:fix/11107/fix-php-mail-warning branch Nov 21, 2018

@MorrisJobke MorrisJobke referenced this pull request Nov 22, 2018

Merged

15.0.0 RC 1 #12581

7 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment