Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix icon variables with app name to avoid conflicts #12421

Merged
merged 1 commit into from Nov 15, 2018

Conversation

@juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Nov 12, 2018

Otherwise apps with the same icon name will overwrite each other.

Example:

deck uses: @include icon-color('app', 'deck', $color-black);
calendar uses: @include icon-color('app', 'calendar', $color-black);

Before:

Both icon variables have the same name --icon-app-000

Before:

deck uses --icon-deck-app-000
calendar uses --icon-calendar-app-000

Copy link
Member

@skjnldsv skjnldsv left a comment

Awesome stuff on your last pr!! You 🎸 !!

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Nov 12, 2018

Jsunit tests failed 🙈

Copy link

@JanDragon JanDragon left a comment

Great

@MorrisJobke MorrisJobke mentioned this pull request Nov 14, 2018
16 of 24 tasks complete
@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Nov 14, 2018

@juliushaertl Would be nice to get them fixed for tomorrow 😃

@juliushaertl juliushaertl force-pushed the bugfix/noid/icons-cacher-app-prefix branch from a95fc1a to 56ad676 Nov 15, 2018
@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Nov 15, 2018

JSUnit still fails 🙈

@juliushaertl juliushaertl force-pushed the bugfix/noid/icons-cacher-app-prefix branch from 56ad676 to da6cf15 Nov 15, 2018
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl force-pushed the bugfix/noid/icons-cacher-app-prefix branch from da6cf15 to 521b2dd Nov 15, 2018
@MorrisJobke MorrisJobke merged commit 7baa67c into master Nov 15, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/drone/pr the build failed
Details
@dco
DCO DCO
Details
@fixupbot
fixupbot Fixup
Details
@MorrisJobke MorrisJobke deleted the bugfix/noid/icons-cacher-app-prefix branch Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants