Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable14] Fix missing quickaccess favorite folder on add #12441

Merged
merged 2 commits into from Nov 14, 2018

Conversation

@newhinton
Copy link
Contributor

@newhinton newhinton commented Nov 13, 2018

Backport to NC14 of #10888

When you mark a folder as favorite, it should be added to the quickaccessbar. This is not the case, because the route for checking if the newly marked element is a folder or a directory is missing. This PR readds the missing route.

…added to favorites

Signed-off-by: fnuesse <felix.nuesse@t-online.de>
Copy link
Contributor

@kesselb kesselb left a comment

👍

*
* @NoAdminRequired
*
* @param String

This comment has been minimized.

*
* @param String
* @return String
*/

This comment has been minimized.

@kesselb

kesselb Nov 14, 2018
Contributor

Please add @throws NotFoundException because get($folderpath)

/**
* Get the node at $path
*
* @param string $path relative path of the file or folder
* @return \OCP\Files\Node
* @throws \OCP\Files\NotFoundException
* @since 6.0.0
*/
public function get($path);
could throw it.

Copy link

@JanDragon JanDragon left a comment

Its Work

@MorrisJobke MorrisJobke changed the title [Backport] Bug/noid/fix missing quickaccess favorite folder on add [stable14] Fix missing quickaccess favorite folder on add Nov 14, 2018
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Tested and works 👍

@MorrisJobke MorrisJobke merged commit c4155e2 into stable14 Nov 14, 2018
1 check passed
1 check passed
@dco
DCO DCO
Details
@MorrisJobke MorrisJobke deleted the stable14-10888 branch Nov 14, 2018
@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Nov 14, 2018

@danielkesselberg I will port the fixes to your comments to master as well.

@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants