New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show thumbnail on rename #12467

Merged
merged 2 commits into from Nov 15, 2018

Conversation

@MorrisJobke
Copy link
Member

MorrisJobke commented Nov 15, 2018

  • does not hide thumbnail when rename is shown
  • fixes layout for grid and list view
  • fixes #11901

Before:

bildschirmfoto 2018-11-15 um 12 18 52
bildschirmfoto 2018-11-15 um 12 18 58


After:

bildschirmfoto 2018-11-15 um 12 18 00

bildschirmfoto 2018-11-15 um 12 15 05

Hovered:
bildschirmfoto 2018-11-15 um 12 15 09

@nextcloud/designers Have a look. I know it involves a lot of CSS fiddling, but I don't want to completely reorder the DOM structure as of now.

Show thumbnail on rename
* does not hide thumbnail when rename is shown
* fixes layout for grid and list view
* fixes #11901

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@skjnldsv
Copy link
Member

skjnldsv left a comment

Looks good to me!

Enhance jsunit tests
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@rullzer
Copy link
Member

rullzer left a comment

Seem to do the trick! Quick smoke tests shows it works

@MorrisJobke MorrisJobke merged commit 790ee0c into master Nov 15, 2018

1 check was pending

continuous-integration/drone/pr this build is pending
Details

@ChristophWurst ChristophWurst deleted the bugfix/11901/show-thumbnail-on-rename branch Nov 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment