Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conflicting multiselect #12468

Merged
merged 1 commit into from Nov 22, 2018
Merged

Remove conflicting multiselect #12468

merged 1 commit into from Nov 22, 2018

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 15, 2018

See #1831
@blizzz can you check the ldap please?

It should be using the other jQuery ui multiselect, this is the last location I could find where it was being used :)

@nextcloud/designers

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Nov 15, 2018

Should this be in 15? Or better wait for 16?

@skjnldsv
Copy link
Member Author

@skjnldsv skjnldsv commented Nov 15, 2018

@MorrisJobke ideally 15. But if this is too complicated, i'll add a stricter css rule to backport it to 15 and make sure we ignore this conflict :)

@skjnldsv
Copy link
Member Author

@skjnldsv skjnldsv commented Nov 15, 2018

I was able to complete the full setup and use the multiselect without any issues. The multiselect in core have nothing to do with the multiselect used in the ldap config
Let's review!

@skjnldsv skjnldsv added this to the Nextcloud 15 milestone Nov 15, 2018
@skjnldsv skjnldsv requested review from juliushaertl and schiessle Nov 16, 2018
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Checked with rg multiselect -g \!3rdparty -t js -M 150 and couldn't find any occurences of a multiselect apart from the Vue one.

👍 (50% 🐘)

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Nov 20, 2018

I'm unsure if we should do this that late in the cycle. Also it looks like ldap is depending on this. It seems there is a second multiselect in LDAP. I tested it as well and it still works fine.

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Works 👍

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Nov 20, 2018

I'm unsure if we should do this that late in the cycle.

I would like to get some feedback from @juliushaertl @rullzer and @nickvergessen about this.

@rullzer
Copy link
Member

@rullzer rullzer commented Nov 20, 2018

It seems to work. Let's do it to avoid weird patches.

@skjnldsv skjnldsv merged commit 654880d into master Nov 22, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/drone/pr the build failed
Details
@dco
DCO DCO
Details
@fixupbot
fixupbot Fixup
Details
@skjnldsv skjnldsv deleted the multiselect-removal-fix branch Nov 22, 2018
@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
7 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants