New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation layout for items that are added on a re-render #12481

Merged
merged 1 commit into from Nov 16, 2018

Conversation

@nickvergessen
Copy link
Member

nickvergessen commented Nov 16, 2018

Bug was not visible until #12153
Now it looks awkward with the externals app

bildschirmfoto von 2018-11-16 10-54-33

Fixes #12464

@skjnldsv

This comment has been minimized.

Copy link
Member

skjnldsv commented Nov 16, 2018

Fix #12464 ?

@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Nov 16, 2018

Fix #12464 ?

Already added ;)

@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Nov 16, 2018

I don't get it. For me the code is locally executed but the result still looks wrong:

bildschirmfoto 2018-11-16 um 11 12 59

I refreshed multiple times, reinstalled, used different browsers ... and still - the newly added apps are still rendered wrongly.

So this does not fix #12481 somehow. for me.

@skjnldsv
Copy link
Member

skjnldsv left a comment

Let me fix that

@skjnldsv skjnldsv force-pushed the bugfix/noid/fix-navigation-layout-of-new-items branch from 10cd800 to 4604a74 Nov 16, 2018

@skjnldsv
Copy link
Member

skjnldsv left a comment

Done.
The span is next to the a, not within it.
I also fixed the size of the apps icons that did not reflect what the php was initially outputting.

Fix navigation layout for items that are added on a re-render
Signed-off-by: Joas Schilling <coding@schilljs.com>

@skjnldsv skjnldsv force-pushed the bugfix/noid/fix-navigation-layout-of-new-items branch from 4604a74 to 44b0d39 Nov 16, 2018

@MorrisJobke
Copy link
Member

MorrisJobke left a comment

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 56fdb22 into master Nov 16, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the bugfix/noid/fix-navigation-layout-of-new-items branch Nov 16, 2018

@MorrisJobke MorrisJobke referenced this pull request Nov 22, 2018

Merged

15.0.0 RC 1 #12581

7 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment