New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable14] Fix wrong share popover opening on share link #12482

Merged
merged 1 commit into from Nov 16, 2018

Conversation

@skjnldsv
Member

skjnldsv commented Nov 16, 2018

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

Fix wrong share popover opening on share link
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

@skjnldsv skjnldsv added this to the Nextcloud 14.0.4 milestone Nov 16, 2018

@skjnldsv skjnldsv self-assigned this Nov 16, 2018

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Nov 16, 2018

To reproduce:

  • having a user/group share
  • click the "enable" on the "share link" entry
  • expected: the menu of the link opens
  • actual: the menu of the user/group share opens
@skjnldsv

This comment has been minimized.

Member

skjnldsv commented Nov 16, 2018

Hum, my bad! I thought I added a more detailed comment here! :(
Thanks @MorrisJobke 🙈

@MorrisJobke

Tested and works 👍

@MorrisJobke MorrisJobke merged commit a79c7c7 into stable14 Nov 16, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the share-menu-click-fix branch Nov 16, 2018

@skjnldsv skjnldsv changed the title from Fix wrong share popover opening on share link to [stable14] Fix wrong share popover opening on share link Nov 16, 2018

This was referenced Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment