New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loader colours for better visibility #12484

Merged
merged 1 commit into from Nov 16, 2018

Conversation

@skjnldsv
Copy link
Member

skjnldsv commented Nov 16, 2018

Fix #12091

Before
capture d ecran_2018-11-16_13-39-37
After
capture d ecran_2018-11-16_13-39-06
@nextcloud/designers
Fix loader colours for better visibility
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@JanDragon
Copy link

JanDragon left a comment

👍

@ChristophWurst

This comment has been minimized.

Copy link
Member

ChristophWurst commented Nov 16, 2018

better visibility

How's this better when the contrast decreases?

@skjnldsv

This comment has been minimized.

Copy link
Member

skjnldsv commented Nov 16, 2018

@ChristophWurst on which location would the contrast be decreased?
You mean like background-dark/darker?

@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Nov 16, 2018

@ChristophWurst on which location would the contrast be decreased?
You mean like background-dark/darker?

For the lower left image ... 🤔

@ChristophWurst

This comment has been minimized.

Copy link
Member

ChristophWurst commented Nov 16, 2018

Thought the spinner itself was made darker but it's actually the background, right? (Don't know where that css var is used)

@skjnldsv

This comment has been minimized.

Copy link
Member

skjnldsv commented Nov 16, 2018

Thought the spinner itself was made darker but it's actually the background, right? (Don't know where that css var is used)

It's the dark part of the spinner that got darker to increase the contrast between the light part and the dark.

@juliushaertl
Copy link
Member

juliushaertl left a comment

Nice. 👍

@MorrisJobke
Copy link
Member

MorrisJobke left a comment

Makes sense 👍

@MorrisJobke MorrisJobke merged commit 8a5ac26 into master Nov 16, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the loader-color-fixes branch Nov 16, 2018

@MorrisJobke MorrisJobke referenced this pull request Nov 22, 2018

Merged

15.0.0 RC 1 #12581

7 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment