New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format Nextcloud Talk clients sessions. #12485

Merged
merged 2 commits into from Nov 22, 2018

Conversation

Projects
None yet
5 participants
@Ivansss
Copy link
Member

Ivansss commented Nov 16, 2018

Format Nextcloud Talk clients (Android & iOS) sessions in Settings.

screen shot 2018-11-16 at 14 50 42

Format Nextcloud Talk clients sessions.
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@mario

This comment has been minimized.

Copy link
Member

mario commented Nov 16, 2018

@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Nov 16, 2018

But this means you have no idea what to revoke if you need to do a revoke of a device?

It Should show the full version on hover.

@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Nov 16, 2018

@Ivansss Would it be possible to send the iOS device name? Because they are quite descriptive (Ivan's iPad, Mario's iPhone, …).

@rullzer

This comment has been minimized.

Copy link
Member

rullzer commented Nov 16, 2018

Well first of all we also do not show this for the main apps.

@Ivansss Would it be possible to send the iOS device name? Because they are quite descriptive (Ivan's iPad, Mario's iPhone, …).

@MorrisJobke the reason for this was exactly that. Iphone apparently encodes the whole string as weird unicode if there is a umlaut or whatever. Which made the DB do 💥

@mario

This comment has been minimized.

Copy link
Member

mario commented Nov 20, 2018

@rullzer iphone does what? :D Aren't we the ones that decide how the data gets sent to the server @Ivansss? :)

@Ivansss I'd assume it's just a matter of properly setting the user agent with the properly encoded data?

@mario

This comment has been minimized.

Copy link
Member

mario commented Nov 20, 2018

@Ivansss and me will take a look at this together next week :)

Fix wording of client sessions
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt
Copy link
Member

jancborchardt left a comment

Fixed some wording. Looks good to me now 👍

We can do fancy device name display or other things in a follow-up pull request?

@MorrisJobke
Copy link
Member

MorrisJobke left a comment

Fine with me 👍

@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Nov 22, 2018

We can do fancy device name display or other things in a follow-up pull request?

Yep 👍

@MorrisJobke MorrisJobke merged commit 0534bcf into master Nov 22, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the nextcloud-talk-sessions-format branch Nov 22, 2018

@MorrisJobke MorrisJobke added this to the Nextcloud 15 milestone Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment