New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused svg api route #12487

Merged
merged 1 commit into from Nov 16, 2018

Conversation

@skjnldsv
Copy link
Member

skjnldsv commented Nov 16, 2018

Fix #12397

@rso42

I could not find anywhere where we use this route.
I think this was a start I added in #9984, but did not continued with this path and used the getSvgFromApp instead 29ff7ef#diff-6f74898d9cb1171c9d9a8f925434de55R81 🤷‍♀️

Remove unused sg api route
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

@skjnldsv skjnldsv added this to the Nextcloud 15 milestone Nov 16, 2018

@skjnldsv skjnldsv self-assigned this Nov 16, 2018

@skjnldsv skjnldsv changed the title Remove unused sg api route Remove unused svg api route Nov 16, 2018

@skjnldsv skjnldsv added 4. to release and removed 3. to review labels Nov 16, 2018

@skjnldsv

This comment has been minimized.

Copy link
Member

skjnldsv commented Nov 16, 2018

Failure unrelated

@skjnldsv skjnldsv merged commit 1942280 into master Nov 16, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@skjnldsv skjnldsv deleted the settings-svg-icons-scss-fix branch Nov 16, 2018

@rullzer

This comment has been minimized.

Copy link
Member

rullzer commented Nov 19, 2018

/backport to stable14

@skjnldsv

This comment has been minimized.

Copy link
Member

skjnldsv commented Nov 20, 2018

Backport in #12542

@MorrisJobke MorrisJobke referenced this pull request Nov 22, 2018

Merged

15.0.0 RC 1 #12581

7 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment