Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use width and opacity for transition #12489

Merged
merged 1 commit into from Nov 16, 2018

Conversation

@juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Nov 16, 2018

This probably fixes #11179

I tried to debug this a bit using browserstack, and it seems to fix the continuous rerendering, which was caused by the transition: all 100ms; rule.

@MorrisJobke Would be great if you could give this a try on a real Safari.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Tested, works and fixes the CPU issue on safari

Copy link

@JanDragon JanDragon left a comment

Tested in Real Mac Os Safari. Works Perfect.

Copy link
Member

@skjnldsv skjnldsv left a comment

🍺 🍺 🍺

@MorrisJobke MorrisJobke merged commit fe13db4 into master Nov 16, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/drone/pr this build is pending
Details
@dco
DCO DCO
Details
@fixupbot
fixupbot Fixup
Details
@MorrisJobke MorrisJobke deleted the bugfix/11179/safari-performance branch Nov 16, 2018
@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Nov 16, 2018

@juliushaertl Could you port this to stable14? I would say it's fine to put it in 14.0.4 still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants