Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix share link password input #12491

Merged
merged 1 commit into from Nov 20, 2018
Merged

Fix share link password input #12491

merged 1 commit into from Nov 20, 2018

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 16, 2018

Fix #12308

Better layout, now clicking outside (which is often supposed to be a cancel action) won't do anything now.
Direct validation by enter key or click is what we want.

peek 16-11-2018 16-18

Also fixed the loading on the sharees autocompletion

Before After
capture d ecran_2018-11-16_15-55-41 capture d ecran_2018-11-16_15-57-00
@skjnldsv
Copy link
Member Author

@skjnldsv skjnldsv commented Nov 20, 2018

Bump!

@skjnldsv skjnldsv added the high label Nov 20, 2018
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Code looks good

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Tested and works 👍

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Nov 20, 2018

JSUnit test fails:

PhantomJS 2.1.1 (Linux 0.0.0) OC.Share.ShareDialogView Share with link update password on focus out FAILED
	Expected false to equal true.
	core/js/tests/specs/sharedialogviewSpec.js:146:48
	TypeError: null is not an object (evaluating 'saveLinkShareStub.firstCall.args') in core/js/tests/specs/sharedialogviewSpec.js (line 147)
	core/js/tests/specs/sharedialogviewSpec.js:147:38
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the share-menu-click-fix branch from 62d5017 to 7a9ea03 Nov 20, 2018
@skjnldsv
Copy link
Member Author

@skjnldsv skjnldsv commented Nov 20, 2018

@skjnldsv skjnldsv merged commit ebc690b into master Nov 20, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/drone/pr the build failed
Details
@dco
DCO DCO
Details
@fixupbot
fixupbot No fixup commits found. The commit history is clean
Details
@skjnldsv skjnldsv deleted the share-menu-click-fix branch Nov 20, 2018
@skjnldsv
Copy link
Member Author

@skjnldsv skjnldsv commented Nov 20, 2018

Backport: #12560

@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
7 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment