New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward object not found error in swift as dav 404 #12500

Merged
merged 2 commits into from Nov 20, 2018

Conversation

Projects
None yet
4 participants
@icewind1991
Copy link
Member

icewind1991 commented Nov 16, 2018

Signed-off-by: Robin Appelman robin@icewind.nl

@MorrisJobke
Copy link
Member

MorrisJobke left a comment

Code makes sense 👍

forward object not found error in switch as dav 404
Signed-off-by: Robin Appelman <robin@icewind.nl>

@MorrisJobke MorrisJobke force-pushed the swift-object-not-found branch from 55c1f70 to 3525192 Nov 19, 2018

@rullzer

This comment has been minimized.

Copy link
Member

rullzer commented Nov 19, 2018

Should we also add this for S3?

@danielkesselberg

This comment has been minimized.

Copy link
Contributor

danielkesselberg commented Nov 19, 2018

/**
* @param string $urn the unified resource name used to identify the object
* @return resource stream with the read data
* @throws \Exception when something goes wrong, message will be logged
* @since 7.0.0
*/
public function readObject($urn);

For nextcloud15 the interface should be adjusted. @throws NotFoundException if file does not exist

Add PHPDoc for thrown exception
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Nov 19, 2018

For nextcloud15 the interface should be adjusted. @throws NotFoundException if file does not exist

Added 👍

@MorrisJobke MorrisJobke merged commit 8e65f08 into master Nov 20, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the swift-object-not-found branch Nov 20, 2018

@MorrisJobke MorrisJobke referenced this pull request Nov 22, 2018

Merged

15.0.0 RC 1 #12581

7 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment