New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirect page design details #12539

Merged
merged 2 commits into from Nov 20, 2018

Conversation

@jancborchardt
Copy link
Member

jancborchardt commented Nov 19, 2018

When you use the Mail app and click on a link, the redirect page looked a bit off, with unreadable heading and non-pill-style button:
redirect text color before redirect page after

Please review @nextcloud/designers :)

jancborchardt added some commits Nov 19, 2018

Fix header text color on redirect page
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Fix CSS specificity preventing buttons displayed in pill style
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@MariusBluem

This comment has been minimized.

Copy link
Member

MariusBluem commented Nov 20, 2018

Dont know if this makes sense, but what do you think about showing the domain as bolt while leaving the rest of the button normal?

@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Nov 20, 2018

Dont know if this makes sense, but what do you think about showing the domain as bolt while leaving the rest of the button normal?

Separate ticket ;)

@MorrisJobke MorrisJobke merged commit 2be8930 into master Nov 20, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the fix-redirect-design branch Nov 20, 2018

@MorrisJobke MorrisJobke referenced this pull request Nov 22, 2018

Merged

15.0.0 RC 1 #12581

7 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment