Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect the disabled setting for lost_password_link #12552

Merged
merged 1 commit into from Nov 20, 2018

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Nov 20, 2018

Fixes #11146
As documented when it is set to disabled the user can't request a lost
password.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Fixes #11146
As documented when it is set to disabled the user can't request a lost
password.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Copy link
Member Author

@rullzer rullzer commented Nov 20, 2018

/backport to stable14

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Tested and works 👍

Copy link
Member

@MariusBluem MariusBluem left a comment

Makes sense :)

@rullzer rullzer merged commit e73bfd5 into master Nov 20, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/drone/pr the build failed
Details
@dco
DCO DCO
Details
@fixupbot
fixupbot No fixup commits found. The commit history is clean
Details
@rullzer rullzer deleted the fix/11146/respect_disabled_password_reset branch Nov 20, 2018
@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Nov 20, 2018

backport to stable14 in #12555

@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
7 of 7 tasks complete
Copy link

@HigH-HawK HigH-HawK left a comment

It works as far as it removes the link from the login page but it causes the LDAP function to misbehave.

As mentioned in the forums: https://help.nextcloud.com/t/ldap-error-in-14-0-4-after-changing-lost-password-link-behaviour-bind-failed-50-insufficient-access/42060

When this change is being done and the user enters a wrong password, the user is getting an internal server error and the NC log states that it could not connect to the LDAP server, despite the LDAP server being available as other users could login fine at the same time.

Further testing brought to daylight, that this behaviour only happens if the entered username is part of the LDAP server. If you enter a fictional username and password, it brings up the correct message "wrong password"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants