New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty string in get absolute url #12553

Merged
merged 2 commits into from Nov 22, 2018

Conversation

Projects
None yet
3 participants
@nickvergessen
Copy link
Member

nickvergessen commented Nov 20, 2018

Ref nextcloud/terms_of_service#35

I didn't know empty string is not allowed and there is also no reason to explicitly break on this.

nickvergessen added some commits Nov 20, 2018

Update the URLGenerator test to current state of art
Signed-off-by: Joas Schilling <coding@schilljs.com>
Allow empty strings in getAbsoluteURL
Signed-off-by: Joas Schilling <coding@schilljs.com>

@nickvergessen nickvergessen added this to the Nextcloud 15 milestone Nov 20, 2018

@MorrisJobke MorrisJobke referenced this pull request Nov 22, 2018

Merged

15.0.0 RC 1 #12581

7 of 7 tasks complete
@MorrisJobke
Copy link
Member

MorrisJobke left a comment

Code makes sense and still works fine 👍

@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Nov 22, 2018

CI failure due to git clone timeout.

@MorrisJobke MorrisJobke merged commit ede53e0 into master Nov 22, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the bugfix/noid/allow-empty-string-in-getAbsoluteURL branch Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment