Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty string in get absolute url #12553

Merged
merged 2 commits into from Nov 22, 2018

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Nov 20, 2018

Ref nextcloud/terms_of_service#35

I didn't know empty string is not allowed and there is also no reason to explicitly break on this.

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 15 milestone Nov 20, 2018
@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
7 of 7 tasks complete
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Code makes sense and still works fine 👍

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Nov 22, 2018

CI failure due to git clone timeout.

@MorrisJobke MorrisJobke merged commit ede53e0 into master Nov 22, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/drone/pr the build failed
Details
@dco
DCO DCO
Details
@fixupbot
fixupbot No fixup commits found. The commit history is clean
Details
@MorrisJobke MorrisJobke deleted the bugfix/noid/allow-empty-string-in-getAbsoluteURL branch Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants