Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better header navigation display #12559

Merged
merged 1 commit into from Nov 22, 2018
Merged

Better header navigation display #12559

merged 1 commit into from Nov 22, 2018

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 20, 2018

Fix #12277

@nextcloud/designers Any opinions? I'm not 100% sold on this. 🤷‍♂️ 🤷‍♀️
peek 20-11-2018 18-41

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@MariusBluem
Copy link
Member

@MariusBluem MariusBluem commented Nov 20, 2018

What about making the text smaller? Dont like that pur main-groupware tools are called „Conta...“ and „Cale...“ 😓

Copy link
Member

@jancborchardt jancborchardt left a comment

This is a good fix for Nextcloud 15! 👍

Anything else we can look into for 16. Making text smaller is not really an option as the text size is already the smallest we should go. We could play around with adding more spacing the apps but then the icons will be spaced too far apart by default.

TL;DR let’s get this in.

@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
7 of 7 tasks complete
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Tested and works 👍

@MorrisJobke MorrisJobke merged commit bebdb19 into master Nov 22, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/drone/pr the build failed
Details
@dco
DCO DCO
Details
@fixupbot
fixupbot No fixup commits found. The commit history is clean
Details
@MorrisJobke MorrisJobke deleted the heading-menu-spacing branch Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants