New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not clear new user form on failure #12587

Merged
merged 1 commit into from Nov 22, 2018

Conversation

@skjnldsv
Copy link
Member

skjnldsv commented Nov 22, 2018

  • And focus the failed input! 馃帀
    Fix #11515

@nextcloud/designers

@MorrisJobke
Copy link
Member

MorrisJobke left a comment

Tested and works 馃憤

@MorrisJobke MorrisJobke referenced this pull request Nov 22, 2018

Merged

15.0.0 RC 1 #12581

7 of 7 tasks complete
@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Nov 22, 2018

@skjnldsv Could you recompile the vue app?

@ChristophWurst
Copy link
Member

ChristophWurst left a comment

Looks good!

Do not clear new user form on failure
Signed-off-by: John Molakvo忙 (skjnldsv) <skjnldsv@protonmail.com>

@skjnldsv skjnldsv force-pushed the new-user-clear-fix branch from 8bbb889 to b28c425 Nov 22, 2018

@skjnldsv

This comment has been minimized.

Copy link
Member

skjnldsv commented Nov 22, 2018

@skjnldsv rebase

@skjnldsv skjnldsv added 4. to release and removed 3. to review labels Nov 22, 2018

@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Nov 22, 2018

Acceptance tests fail:

  Scenario: create folder in a public editable shared folder        # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:207
    Given I act as John                                             # ActorContext::iActAs()
    And I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Editable shared folder"        # FileListContext::iCreateANewFolderNamed()
    And I close the details view                                    # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                       # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I share the link for "Editable shared folder"               # FilesAppContext::iShareTheLinkFor()
    And I set the shared link as editable                           # FilesAppContext::iSetTheSharedLinkAsEditable()
    And I write down the shared link                                # FilesAppContext::iWriteDownTheSharedLink()
      Element is no longer attached to the DOM
      For documentation on this error, please visit: http://seleniumhq.org/exceptions/stale_element_reference.html
      Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
      System info: host: '0a91777a3a8d', ip: '172.17.0.4', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-38-generic', java.version: '1.8.0_91'
      Driver info: driver.version: unknown (WebDriver\Exception\StaleElementReference)
    When I act as Jane                                              # ActorContext::iActAs()
    And I visit the shared link I wrote down                        # FilesSharingAppContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down # FilesSharingAppContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I create a new folder named "Subfolder"                     # FileListContext::iCreateANewFolderNamed()
    Then I see that the file list contains a file named "Subfolder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Nov 22, 2018

Acceptance tests fail:

Ah no - this is unrelated to the changes in here. Either a regression on master or a false positive. 馃檲

@MorrisJobke MorrisJobke merged commit e0967ff into master Nov 22, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the new-user-clear-fix branch Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment