Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable15] Make acceptance tests for comments more robust #12696

Merged
merged 2 commits into from Nov 27, 2018

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Nov 27, 2018

backport of #12649

danxuliu added 2 commits Nov 24, 2018
When the "Comments" tab is open the empty content element is always in
the DOM, although it is only shown once the message collection was
fetched and there were no messages. Due to this it is necessary to
explicitly wait for it to be shown instead of relying on the implicit
wait made to find the element; otherwise it would be found immediately
and if the collection was not fetched yet it would not be visible,
causing the test to fail.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
If the server is too slow, changing to a different file immediately
after sending a new comment but without waiting for the comment to be
shown for the original file could cause the new comment to be shown for
the current file instead.

This is, indeed, a bug in the comments. However, it is not possible to
test it reliably in the acceptance tests, as it depends on how fast the
server adds the message and how fast the client changes to a different
file; sometimes the test would fail and sometimes it would not.

Therefore, now it is waited for the comment to be added before changing
to another file, as in this case it can be reliably tested that changing
to a different file does not cause the comments from the previous file
to be shown in the current file (this was a different bug already fixed
and due to which this test was added in the first place).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Copy link
Member

@danxuliu danxuliu left a comment

Tested and works 👍 (although maybe I should not review due to being the original author?)

Copy link
Contributor

@kesselb kesselb left a comment

CI is happy again 👍

@kesselb kesselb added this to the Nextcloud 15 milestone Nov 27, 2018
@kesselb kesselb merged commit 5ea9932 into stable15 Nov 27, 2018
3 checks passed
3 checks passed
@dco
DCO DCO
Details
continuous-integration/drone/pr the build was successful
Details
@fixupbot
fixupbot No fixup commits found. The commit history is clean
Details
@kesselb kesselb deleted the backport/12649/stable15 branch Nov 27, 2018
@MorrisJobke MorrisJobke mentioned this pull request Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants