Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable15] Fix password confirmation lib for ie11 #12863

Merged
merged 1 commit into from Dec 5, 2018

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Dec 5, 2018

Fixes #12806 for Nextcloud 15.

The previous version did not convert arrow functions to es5 functions. Ref nextcloud/nextcloud-password-confirmation#2.

@skjnldsv could you verify it works on IE?

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Christoph's Tasks automation moved this from IN PROGRESS (max 3 PRs) to TO INTEGRATE Dec 5, 2018
@rullzer
rullzer approved these changes Dec 5, 2018
Copy link
Member

@rullzer rullzer left a comment

🐘

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Dec 5, 2018

@ChristophWurst What about master?

@MorrisJobke MorrisJobke mentioned this pull request Dec 5, 2018
12 of 12 tasks complete
@MorrisJobke MorrisJobke merged commit 61c17b5 into stable15 Dec 5, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/drone/pr this build is pending
Details
@dco
DCO DCO
Details
@fixupbot
fixupbot No fixup commits found. The commit history is clean
Details
Christoph's Tasks automation moved this from TO INTEGRATE to DONE Dec 5, 2018
@MorrisJobke MorrisJobke deleted the fix/stable15-fix-password-confirmation-ie11 branch Dec 5, 2018
@ChristophWurst
Copy link
Member Author

@ChristophWurst ChristophWurst commented Dec 6, 2018

@ChristophWurst What about master?

Fixed via #12859 (comment).

@ChristophWurst
Copy link
Member Author

@ChristophWurst ChristophWurst commented Dec 6, 2018

@skjnldsv could you verify it works on IE?

Can I take your positive review as a yes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants