New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable15] Fix password confirmation lib for ie11 #12863

Merged
merged 1 commit into from Dec 5, 2018

Conversation

@ChristophWurst
Copy link
Member

ChristophWurst commented Dec 5, 2018

Fixes #12806 for Nextcloud 15.

The previous version did not convert arrow functions to es5 functions. Ref ChristophWurst/nextcloud-password-confirmation#2.

@skjnldsv could you verify it works on IE?

Fix password confirmation lib for ie11
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

@ChristophWurst ChristophWurst added this to the Nextcloud 15 milestone Dec 5, 2018

@ChristophWurst ChristophWurst self-assigned this Dec 5, 2018

@ChristophWurst ChristophWurst added this to IN PROGRESS (max 3 PRs) in Christoph's Tasks via automation Dec 5, 2018

@ChristophWurst ChristophWurst requested a review from skjnldsv Dec 5, 2018

Christoph's Tasks automation moved this from IN PROGRESS (max 3 PRs) to TO INTEGRATE Dec 5, 2018

@rullzer

rullzer approved these changes Dec 5, 2018

Copy link
Member

rullzer left a comment

🐘

@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Dec 5, 2018

@ChristophWurst What about master?

@MorrisJobke MorrisJobke referenced this pull request Dec 5, 2018

Merged

15.0.0 RC 3 #12847

12 of 12 tasks complete

@MorrisJobke MorrisJobke merged commit 61c17b5 into stable15 Dec 5, 2018

1 check was pending

continuous-integration/drone/pr this build is pending
Details

Christoph's Tasks automation moved this from TO INTEGRATE to DONE Dec 5, 2018

@MorrisJobke MorrisJobke deleted the fix/stable15-fix-password-confirmation-ie11 branch Dec 5, 2018

@ChristophWurst

This comment has been minimized.

Copy link
Member

ChristophWurst commented Dec 6, 2018

@ChristophWurst What about master?

Fixed via #12859 (comment).

@ChristophWurst

This comment has been minimized.

Copy link
Member

ChristophWurst commented Dec 6, 2018

@skjnldsv could you verify it works on IE?

Can I take your positive review as a yes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment