New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Move navigation entries without order to the end #1299

Merged
merged 1 commit into from Sep 7, 2016

Conversation

Projects
None yet
4 participants
@MorrisJobke
Member

MorrisJobke commented Sep 7, 2016

cc @nickvergessen @LukasReschke @rullzer

This fixes the log spam with:

Undefined index: order at lib/private/legacy/app.php(511) : runtime-created function#1

cc @karlitschek

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Sep 7, 2016

Member

👍 although I think we should throw an exception instead. The API clearly states that this is needed :-<

Member

nickvergessen commented Sep 7, 2016

👍 although I think we should throw an exception instead. The API clearly states that this is needed :-<

@karlitschek

This comment has been minimized.

Show comment
Hide comment
@karlitschek

karlitschek Sep 7, 2016

Member

nice. please backport 👍

Member

karlitschek commented Sep 7, 2016

nice. please backport 👍

@rullzer rullzer added 4. to release and removed 3. to review labels Sep 7, 2016

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Sep 7, 2016

Member

although I think we should throw an exception instead. The API clearly states that this is needed :-<

This doesn't help with apps, that don't respect this. It worked in the past so we should not explode all out of the sudden. 😢

Member

MorrisJobke commented Sep 7, 2016

although I think we should throw an exception instead. The API clearly states that this is needed :-<

This doesn't help with apps, that don't respect this. It worked in the past so we should not explode all out of the sudden. 😢

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Sep 7, 2016

Member

No, it never worked: https://github.com/nextcloud/server/blob/stable9/lib/private/app.php#L456
Also stable9 throws undefined index

Member

nickvergessen commented Sep 7, 2016

No, it never worked: https://github.com/nextcloud/server/blob/stable9/lib/private/app.php#L456
Also stable9 throws undefined index

@MorrisJobke MorrisJobke merged commit 2880a08 into stable10 Sep 7, 2016

4 checks passed

Scrutinizer 1 updated code elements
Details
approvals/lgtm this commit looks good
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MorrisJobke MorrisJobke deleted the stable10-backport-1235 branch Sep 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment