New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Fix OS X and OVH problems #1331

Merged
merged 2 commits into from Sep 9, 2016

Conversation

Projects
None yet
4 participants
@LukasReschke
Member

LukasReschke commented Sep 8, 2016

Backport of #1328 and #797

LukasReschke added some commits Sep 8, 2016

Add exemptions for incompatible UAs
Some user agents are notorious and don't really properly follow HTTP
 specifications. For those, have an automated opt-out. Since the protection
for remote.php is applied in base.php as starting point we need to opt out
here.
Match only for actual session cookie
OVH has implemented load balancing in a very questionable way where the reverse proxy actually internally adds some cookies which would trigger a security exception. To work around this, this change only checks for the session cookie.
@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Sep 8, 2016

Member

Tested and works 👍

Member

MorrisJobke commented Sep 8, 2016

Tested and works 👍

@tflidd

This comment has been minimized.

Show comment
Hide comment
@tflidd

tflidd Sep 8, 2016

Contributor

Tested on NC 10.0 with OS X 10.9 👍

Contributor

tflidd commented Sep 8, 2016

Tested on NC 10.0 with OS X 10.9 👍

@rullzer rullzer merged commit b9100da into stable10 Sep 9, 2016

3 of 4 checks passed

approvals/lgtm 1 of 2 required approvals granted
Scrutinizer 3 new issues, 2 updated code elements
Details
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rullzer rullzer deleted the osx-problems-stable10 branch Sep 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment