New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow increasing permissions for share owner #1376

Merged
merged 2 commits into from Sep 13, 2016

Conversation

Projects
None yet
4 participants
@MorrisJobke
Member

MorrisJobke commented Sep 12, 2016

In some cases, the owner of the share is also recipient through a group
share. The owner must still be able to increase permissions in that
situation.

cc @rullzer @icewind1991 @schiessle

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Sep 12, 2016

I tested this and it is fixed with this branch. 👍

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Sep 12, 2016

@karlitschek I would like to backport this to stable10 and stable9 as they are affected too.

@rullzer

This comment has been minimized.

Member

rullzer commented Sep 13, 2016

Fixed the tests

LGTM

@karlitschek

This comment has been minimized.

Member

karlitschek commented Sep 13, 2016

please backport 👍

PVince81 and others added some commits Aug 29, 2016

Allow increasing permissions for share owner
In some cases, the owner of the share is also recipient through a group
share. The owner must still be able to increase permissions in that
situation.

@MorrisJobke MorrisJobke merged commit f8450e5 into master Sep 13, 2016

4 checks passed

Scrutinizer No new issues
Details
approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MorrisJobke MorrisJobke deleted the upstream-25966 branch Sep 13, 2016

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Sep 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment