New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MissingMandatoryParametersException for share notifications #1394

Merged
merged 1 commit into from Sep 13, 2016

Conversation

Projects
None yet
4 participants
@nickvergessen
Member

nickvergessen commented Sep 13, 2016

The routing system is non-forgiving.

@rullzer @schiessle

Steps

  1. Enable share notifications
  2. Set up a second user with email
  3. Share a file with the user
  4. Send notification

Expected

Email is sent, return is 200

Actual

Symfony\Component\Routing\Exception\MissingMandatoryParametersException
Some mandatory parameters are missing ("fileid") to generate a URL for route "files.viewcontroller.showFile"

No email

Fix #1277

Fix MissingMandatoryParametersException for share notifications
The routing system is non-forgiving
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Sep 13, 2016

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @rullzer, @LukasReschke and @schiessle to be potential reviewers

mention-bot commented Sep 13, 2016

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @rullzer, @LukasReschke and @schiessle to be potential reviewers

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Sep 13, 2016

Member

Tested and works 👍

Member

MorrisJobke commented Sep 13, 2016

Tested and works 👍

@rullzer

This comment has been minimized.

Show comment
Hide comment
@rullzer

rullzer Sep 13, 2016

Member

LGTM

Member

rullzer commented Sep 13, 2016

LGTM

@rullzer rullzer merged commit 43bff15 into stable10 Sep 13, 2016

3 of 4 checks passed

approvals/lgtm 1 of 2 required approvals granted
Scrutinizer No new issues
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rullzer rullzer deleted the fix-share-notification-10 branch Sep 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment