Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable15] Do not do redirect handling when loggin out #14275

Merged
merged 1 commit into from Feb 20, 2019

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Feb 18, 2019

Backport of #12573

Fixes #12568
Since the clearing of the execution context causes another reload. We
should not do the redirect_uri handling as this results in redirecting
back to the logout page on login.

This adds a simple middleware that will just check if the
ClearExecutionContext session variable is set. If that is the case it
will just redirect back to the login page.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Tested and works 👍

@rullzer
Copy link
Member Author

@rullzer rullzer commented Feb 20, 2019

Also +1 from me obiously 😉

@rullzer rullzer merged commit 6e110c3 into stable15 Feb 20, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/drone/pr the build failed
Details
@dco
DCO DCO
Details
@fixupbot
fixupbot No fixup commits found. The commit history is clean
Details
@rullzer rullzer deleted the backport/12573/stable15 branch Feb 20, 2019
@MorrisJobke MorrisJobke mentioned this pull request Feb 20, 2019
4 tasks done
@Ravinou
Copy link

@Ravinou Ravinou commented Mar 11, 2019

hi !
It didn't work for me. I just installed Nextcloud 15.0.5 and when i log out, URL is the same. Issue 12568 is not solved for me : #12568 (comment)

I'm on Firefox 65.0.1

EDIT : i clean my browser cache and it seems to work. Sometimes randomly, it's strange but it seems it works sorry. Thank you for your work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants