Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #13319: load oc-backbone-webdav before loading versions app #14472

Merged
merged 1 commit into from Mar 4, 2019
Merged

Conversation

@felixn
Copy link

@felixn felixn commented Mar 2, 2019

See issue #13319

… app

Signed-off-by: Felix Nieuwenhuizen <felix@tdlrali.com>
@felixn
Copy link
Author

@felixn felixn commented Mar 2, 2019

Inspired by the comments app:

Util::addScript('oc-backbone-webdav');
Util::addScript('comments', 'merged');

Loading

rullzer
rullzer approved these changes Mar 4, 2019
Copy link
Member

@rullzer rullzer left a comment

Yes good point!

Loading

@rullzer rullzer added this to the Nextcloud 15.0.6 milestone Mar 4, 2019
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Makes sense 👍

Loading

@rullzer rullzer merged commit 4ee9069 into nextcloud:stable15 Mar 4, 2019
2 of 3 checks passed
Loading
@felixn felixn deleted the stable15 branch Mar 4, 2019
@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Mar 4, 2019

@rullzer backport?

Loading

@rullzer
Copy link
Member

@rullzer rullzer commented Mar 4, 2019

I think this only affects 15.
In 16 this si alays bundled. And before 15 doesn't use the webdav yet I think

Loading

@juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Mar 4, 2019

Yes, just tested and works fine with 16.

Loading

@rullzer rullzer mentioned this pull request Mar 29, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants