Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #13319: load oc-backbone-webdav before loading versions app #14472

Merged
merged 1 commit into from Mar 4, 2019

Conversation

Projects
None yet
5 participants
@felixn
Copy link

felixn commented Mar 2, 2019

See issue #13319

Felix Nieuwenhuizen
Fix for issue #13319: load oc-backbone-webdav before loading versions…
… app

Signed-off-by: Felix Nieuwenhuizen <felix@tdlrali.com>
@felixn

This comment has been minimized.

Copy link
Author

felixn commented Mar 2, 2019

Inspired by the comments app:

Util::addScript('oc-backbone-webdav');
Util::addScript('comments', 'merged');

@rullzer

rullzer approved these changes Mar 4, 2019

Copy link
Member

rullzer left a comment

Yes good point!

@rullzer rullzer added this to the Nextcloud 15.0.6 milestone Mar 4, 2019

@rullzer rullzer requested review from MorrisJobke and ChristophWurst Mar 4, 2019

@ChristophWurst
Copy link
Member

ChristophWurst left a comment

Makes sense 👍

@rullzer rullzer merged commit 4ee9069 into nextcloud:stable15 Mar 4, 2019

1 check failed

continuous-integration/drone/pr the build failed
Details

@felixn felixn deleted the felixn:stable15 branch Mar 4, 2019

@ChristophWurst

This comment has been minimized.

Copy link
Member

ChristophWurst commented Mar 4, 2019

@rullzer backport?

@rullzer

This comment has been minimized.

Copy link
Member

rullzer commented Mar 4, 2019

I think this only affects 15.
In 16 this si alays bundled. And before 15 doesn't use the webdav yet I think

@juliushaertl

This comment has been minimized.

Copy link
Member

juliushaertl commented Mar 4, 2019

Yes, just tested and works fine with 16.

@rullzer rullzer referenced this pull request Mar 29, 2019

Merged

15.0.6 RC 1 #14909

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.