Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable15] Do not cut full color on accessibility svg color invert #14516

Merged
merged 1 commit into from Mar 5, 2019

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Mar 4, 2019

backport of #14499

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Code makes sense 👍

Loading

@faily-bot
Copy link

@faily-bot faily-bot bot commented Mar 4, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16722: failure

  • TESTS=acceptance, TESTS-ACCEPTANCE=app-files
    • tests/acceptance/features/app-files.feature:133
    • tests/acceptance/features/app-files.feature:172
Show full log
  Scenario: show deleted files for a second time                      # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:133
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I open the "Deleted files" section                            # AppNavigationContext::iOpenTheSection()
    And I see that the current section is "Deleted files"             # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    And I open the "All files" section                                # AppNavigationContext::iOpenTheSection()
    And I see that the current section is "All files"                 # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    And I delete "welcome.txt"                                        # FileListContext::iDelete()
    When I open the "Deleted files" section                           # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Deleted files"            # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
  Scenario: copy a file to another folder                            # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:172
    Given I am logged in                                             # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Destination"                    # FileListContext::iCreateANewFolderNamed()
    When I start the move or copy operation for "welcome.txt"        # FileListContext::iStartTheMoveOrCopyOperationFor()
    And I select "Destination" in the file picker                    # FilePickerContext::iSelectInTheFilePicker()
      Row for file Destination in the file picker dialog could not be found after 100 seconds (NoSuchElementException)
    And I copy to the last selected folder in the file picker        # FilePickerContext::iCopyToTheLastSelectedFolderInTheFilePicker()
    Then I enter in the folder named "Destination"                   # FileListContext::iEnterInTheFolderNamed()
    And I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I open the Files app                                         # FilesAppContext::iOpenTheFilesApp()
    And I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

Loading

@MorrisJobke MorrisJobke merged commit 0f95b95 into stable15 Mar 5, 2019
2 of 3 checks passed
Loading
@ChristophWurst ChristophWurst deleted the backport/14499/stable15 branch Mar 5, 2019
@rullzer rullzer mentioned this pull request Mar 29, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants