Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable15] dav: Fix handling of chunked WebDAV upload #14517

Merged
merged 1 commit into from Mar 5, 2019

Conversation

Projects
None yet
3 participants
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 4, 2019

backport of #13871

dav: Fix handling of chunked WebDAV upload
When $data is null (which can happen when $request->getBodyAsStream() returns
null), the Exceptions says "copied bytes: 0, expected filesize: 0", which
sounds more like success...
@faily-bot

This comment has been minimized.

Copy link

faily-bot bot commented Mar 4, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16724: failure

  • DB=mysqlmb4, ENABLE_REDIS=false, PHP=7.3
Show full log
There was 1 failure:

1) TrashbinTest::testExpireOldFiles
Failed asserting that null is identical to 'file2.txt'.

/drone/src/github.com/nextcloud/server/apps/files_trashbin/tests/TrashbinTest.php:186

--

There was 1 risky test:

1) OCA\TwoFactorBackupCodes\Tests\Db\BackupCodeMapperTest::testInsertArgonEncryptedCodes
This test did not perform any assertions

  • TESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing-link
    • tests/acceptance/features/app-files-sharing-link.feature:81
Show full log
  Scenario: owner sees folder created in the public page of an editable shared folder # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-sharing-link.feature:81
    Given I act as John                                                               # ActorContext::iActAs()
    And I am logged in                                                                # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Editable shared folder"                          # FileListContext::iCreateANewFolderNamed()
    And I close the details view                                                      # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                         # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I share the link for "Editable shared folder"                                 # FilesAppSharingContext::iShareTheLinkFor()
    And I set the shared link as editable                                             # FilesAppSharingContext::iSetTheSharedLinkAsEditable()
    And I write down the shared link                                                  # FilesAppSharingContext::iWriteDownTheSharedLink()
      Element is no longer attached to the DOM
      For documentation on this error, please visit: http://seleniumhq.org/exceptions/stale_element_reference.html
      Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
      System info: host: 'ba1f1ef28e3d', ip: '172.17.0.11', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-43-generic', java.version: '1.8.0_91'
      Driver info: driver.version: unknown (WebDriver\Exception\StaleElementReference)
    And I act as Jane                                                                 # ActorContext::iActAs()
    And I visit the shared link I wrote down                                          # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down                   # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    And I create a new folder named "Subfolder"                                       # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Subfolder"                    # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I act as John                                                                # ActorContext::iActAs()
    And I enter in the folder named "Editable shared folder"                          # FileListContext::iEnterInTheFolderNamed()
    Then I see that the file list contains a file named "Subfolder"                   # FileListContext::iSeeThatTheFileListContainsAFileNamed()
@MorrisJobke
Copy link
Member

MorrisJobke left a comment

Code makes sense 👍

@cowai

cowai approved these changes Mar 5, 2019

Copy link
Member

cowai left a comment

Looks good to me.

@MorrisJobke MorrisJobke merged commit 6e5a930 into stable15 Mar 5, 2019

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the backport/13871/stable15 branch Mar 5, 2019

@rullzer rullzer referenced this pull request Mar 29, 2019

Merged

15.0.6 RC 1 #14909

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.