Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable15] Add activities for group membership changes #14534

Conversation

@nickvergessen
Copy link
Member

nickvergessen commented Mar 5, 2019

backport #14502

nickvergessen added some commits Mar 4, 2019

Add activities for group membership changes
Signed-off-by: Joas Schilling <coding@schilljs.com>
Update autoloader
Signed-off-by: Joas Schilling <coding@schilljs.com>
@MorrisJobke
Copy link
Member

MorrisJobke left a comment

Tested and works 👍

@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Mar 5, 2019

CI failures

@nickvergessen

This comment has been minimized.

Copy link
Member Author

nickvergessen commented Mar 6, 2019

Fixed

@nextcloud nextcloud deleted a comment from faily-bot bot Mar 6, 2019

@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Mar 6, 2019

Still some of them fail 🙈

Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>

@nickvergessen nickvergessen force-pushed the backport/14502/add-activities-for-group-membership-changes branch from 3ef6582 to fee02bb Mar 7, 2019

@nickvergessen

This comment has been minimized.

Copy link
Member Author

nickvergessen commented Mar 7, 2019

arg, :void is 7.1+

Fixed

@faily-bot

This comment has been minimized.

Copy link

faily-bot bot commented Mar 7, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 16842: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-files

  • tests/acceptance/features/app-files.feature:41
  • tests/acceptance/features/app-files.feature:72
Show full log
  Scenario: viewing a favorite file in its folder shows the correct sidebar view # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:41
    Given I am logged in                                                         # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "other"                                      # FileListContext::iCreateANewFolderNamed()
    And I mark "other" as favorite                                               # FileListContext::iMarkAsFavorite()
    And I mark "welcome.txt" as favorite                                         # FileListContext::iMarkAsFavorite()
    And I see that "other" is marked as favorite                                 # FileListContext::iSeeThatIsMarkedAsFavorite()
    And I see that "welcome.txt" is marked as favorite                           # FileListContext::iSeeThatIsMarkedAsFavorite()
    And I open the "Favorites" section                                           # AppNavigationContext::iOpenTheSection()
    And I open the details view for "other"                                      # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                      # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I see that the file name shown in the details view is "other"            # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()
    When I view "welcome.txt" in folder                                          # FileListContext::iViewInFolder()
      Row for file welcome.txt in file list could not be found after 100 seconds
      File actions menu button for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
    Then I see that the current section is "All files"                           # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    And I see that the details view is open                                      # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I see that the file name shown in the details view is "welcome.txt"      # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()
    When I open the details view for "other"                                     # FileListContext::iOpenTheDetailsViewFor()
    And I see that the file name shown in the details view is "other"            # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()

  Scenario: show recent files                                                 # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:72
    Given I am logged in                                                      # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Folder just created"                     # FileListContext::iCreateANewFolderNamed()
    When I open the "Recent" section                                          # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Recent"                           # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "Folder just created" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file Folder just created in file list could not be found after 100 seconds (NoSuchElementException)

@MorrisJobke MorrisJobke merged commit 634390a into stable15 Mar 8, 2019

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the backport/14502/add-activities-for-group-membership-changes branch Mar 8, 2019

@rullzer rullzer referenced this pull request Mar 29, 2019

Merged

15.0.6 RC 1 #14909

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.