Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable15] improve lookup server behaviour #14696

Merged
merged 4 commits into from Mar 18, 2019
Merged

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Mar 14, 2019

backport of #13401

Copy link
Member

@rullzer rullzer left a comment

🐘

Loading

@nextcloud nextcloud deleted a comment from faily-bot bot Mar 15, 2019
schiessle added 2 commits Mar 17, 2019
Don't try to connect to the lookup server if the lookup server was disabled
by the admin or an empty lookup server URL was given

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
@rullzer rullzer force-pushed the backport/13401/stable15 branch from c89cb30 to edbe99d Mar 17, 2019
@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Mar 17, 2019

[Sun Mar 17 19:52:15 2019] Undefined property: OCA\LookupServerConnector\UpdateLookupServer::$config at /drone/src/github.com/nextcloud/server/apps/lookup_server_connector/lib/UpdateLookupServer.php#73
[Sun Mar 17 19:52:15 2019] Error: Call to a member function getAppValue() on null at /drone/src/github.com/nextcloud/server/apps/lookup_server_connector/lib/UpdateLookupServer.php#73

🙈

Loading

kesselb and others added 2 commits Mar 18, 2019
…:$config

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@rullzer
Copy link
Member

@rullzer rullzer commented Mar 18, 2019

Also applied #14519 and #14529

Loading

@faily-bot
Copy link

@faily-bot faily-bot bot commented Mar 18, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17110: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-comments

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

TESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

Loading

@rullzer rullzer merged commit 3f559dd into stable15 Mar 18, 2019
2 of 3 checks passed
Loading
@rullzer rullzer deleted the backport/13401/stable15 branch Mar 18, 2019
@rullzer rullzer mentioned this pull request Mar 29, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants