Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable15] improve lookup server behaviour #14696

Merged
merged 4 commits into from Mar 18, 2019

Conversation

Projects
None yet
4 participants
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 14, 2019

backport of #13401

@rullzer
Copy link
Member

rullzer left a comment

🐘

@rullzer rullzer added 4. to release and removed 3. to review labels Mar 14, 2019

@nextcloud nextcloud deleted a comment from faily-bot bot Mar 15, 2019

schiessle added some commits Jan 7, 2019

improve lookup server behaviour
Don't try to connect to the lookup server if the lookup server was disabled
by the admin or an empty lookup server URL was given

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
increase timespan between each retry
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

@rullzer rullzer force-pushed the backport/13401/stable15 branch from c89cb30 to edbe99d Mar 17, 2019

@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Mar 17, 2019

[Sun Mar 17 19:52:15 2019] Undefined property: OCA\LookupServerConnector\UpdateLookupServer::$config at /drone/src/github.com/nextcloud/server/apps/lookup_server_connector/lib/UpdateLookupServer.php#73
[Sun Mar 17 19:52:15 2019] Error: Call to a member function getAppValue() on null at /drone/src/github.com/nextcloud/server/apps/lookup_server_connector/lib/UpdateLookupServer.php#73

🙈

kesselb and others added some commits Mar 4, 2019

Fix Undefined property: OCA\LookupServerConnector\UpdateLookupServer:…
…:$config

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Fix missing $config dependency in RetryJob
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@rullzer

This comment has been minimized.

Copy link
Member

rullzer commented Mar 18, 2019

Also applied #14519 and #14529

@faily-bot

This comment has been minimized.

Copy link

faily-bot bot commented Mar 18, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17110: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-comments

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

TESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

@rullzer rullzer merged commit 3f559dd into stable15 Mar 18, 2019

1 check failed

continuous-integration/drone/pr the build failed
Details

@rullzer rullzer deleted the backport/13401/stable15 branch Mar 18, 2019

@rullzer rullzer referenced this pull request Mar 29, 2019

Merged

15.0.6 RC 1 #14909

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.