Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable15] dont try to restore a trashbin item to a readonly target #14699

Merged
merged 1 commit into from Mar 15, 2019

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Mar 14, 2019

backport of #14693

Signed-off-by: Robin Appelman <robin@icewind.nl>
@faily-bot
Copy link

@faily-bot faily-bot bot commented Mar 15, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17040: failure

ENABLE_REDIS=true, TESTS=integration-ratelimiting

TESTS=acceptance, TESTS-ACCEPTANCE=users

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

TESTS=sqlite-php7.0-samba-non-native

Show full log
There was 1 failure:

1) OCA\Files_External\Tests\Storage\SmbTest::testNotifyGetChanges
Actual changes are:
Array
(
    [0] => OC\Files\Notify\Change Object
        (
            [type:OC\Files\Notify\Change:private] => 1
            [path:OC\Files\Notify\Change:private] => newfile.txt
        )

    [1] => OC\Files\Notify\RenameChange Object
        (
            [targetPath:OC\Files\Notify\RenameChange:private] => renamed.txt
            [type:OC\Files\Notify\Change:private] => 4
            [path:OC\Files\Notify\Change:private] => newfile.txt
        )

    [2] => OC\Files\Notify\Change Object
        (
            [type:OC\Files\Notify\Change:private] => 2
            [path:OC\Files\Notify\Change:private] => renamed.txt
        )

)

Failed asserting that an array contains OC\Files\Notify\RenameChange Object &0000000061087c3f000000004573634d (
    'targetPath' => 'renamed.txt'
    'type' => 4
    'path' => 'newfile.txt'
).

/drone/src/github.com/nextcloud/server/apps/files_external/tests/Storage/SmbTest.php:124

TESTS=ui-regression

Loading

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Mar 15, 2019

@icewind1991 I'm confused: the object that is searched is actually in the change list, but somehow the test doesn't find it 🙈

Loading

@MorrisJobke MorrisJobke merged commit ab492ad into stable15 Mar 15, 2019
2 of 3 checks passed
Loading
@MorrisJobke MorrisJobke deleted the backport/14693/stable15 branch Mar 15, 2019
@rullzer rullzer mentioned this pull request Mar 29, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants