Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable15] groupname like username - allow share with both #14709

Conversation

Projects
None yet
4 participants
@aignerat
Copy link
Contributor

aignerat commented Mar 15, 2019

It happens that users and groups have the same name in big organizations, the nextcloud standard behaviour is like this: I can only share with the user or the group.
With this small extension it's possible to share files with the group "test" and the user "test" at the same time.

I added this feature, because it makes no sense to me to disallow the sharing because of the same name of a group and an user.

groupname like username - allow share with both
Signed-off-by: Christian Aigner <christian.aigner@huemer-it.com>
@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Mar 20, 2019

/backport to master

@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Mar 20, 2019

Usually we first develop something against master and then backport to the stable branches. But for this one it's okay to do it the other way around.

@ChristophWurst
Copy link
Member

ChristophWurst left a comment

Makes sense

MorrisJobke and others added some commits Mar 20, 2019

Update lib/private/Share20/Manager.php
fixed tabulator

Co-Authored-By: aignerat <46312655+aignerat@users.noreply.github.com>
Update lib/private/Share20/Manager.php
tabulator change

Co-Authored-By: aignerat <46312655+aignerat@users.noreply.github.com>
@MorrisJobke
Copy link
Member

MorrisJobke left a comment

Code makes sense and works 👍

@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented Mar 20, 2019

Status of 17173: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

TESTS=acceptance, TESTS-ACCEPTANCE=app-files-sharing-link

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

@MorrisJobke MorrisJobke merged commit 8781a77 into nextcloud:stable15 Mar 20, 2019

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke changed the title groupname like username - allow share with both [stable15] groupname like username - allow share with both Mar 20, 2019

@backportbot-nextcloud

This comment has been minimized.

Copy link

backportbot-nextcloud bot commented Mar 20, 2019

backport to master in #14766

@rullzer rullzer referenced this pull request Mar 29, 2019

Merged

15.0.6 RC 1 #14909

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.