Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation go.php to 15 and adjusted copyright year. #14716

Merged
merged 1 commit into from Mar 18, 2019

Conversation

@Faldon
Copy link
Contributor

@Faldon Faldon commented Mar 15, 2019

Updated stable version

  • The stable version number now is 15
  • Updated copyright year to 2019

Fixes #14650

Signed-off-by: Thomas Pulzer <t.pulzer@thesecretgamer.de>
@Faldon Faldon force-pushed the update_document_version branch from 8b20f30 to 7233c0e Mar 15, 2019
@kesselb
Copy link
Contributor

@kesselb kesselb commented Mar 15, 2019

Fixes #14650

Only if someone uses "example" as theme 😎

@kesselb
Copy link
Contributor

@kesselb kesselb commented Mar 15, 2019

#11304 we had some discussions about this (see the resolved conversation). I think we should go for \OC_Util::getVersion()[0] instead of 14,15,16...

@Faldon
Copy link
Contributor Author

@Faldon Faldon commented Mar 16, 2019

Dynamic resolving would be definitely better. 😃
The reason why I thought "If any, it should go to the stable branch."

Of course, if the version number can be resolved dynamically, than that's the better approach. Is this just legacy remains or is there a reason that anything in the affected file is hardcoded respectively has no dependency on any other file?

@kesselb
Copy link
Contributor

@kesselb kesselb commented Mar 16, 2019

Is this just legacy remains or is there a reason that anything in the affected file is hardcoded respectively has no dependency on any other file?

This file is not used anywhere. It's an example for a custom theme.

@Faldon
Copy link
Contributor Author

@Faldon Faldon commented Mar 16, 2019

Ah, I see.
But to reproduce the issue #14650 I referenced, I set up a complete new development instance. If this file is for example themes, a fresh installation without any modification theme-wise should not call this code then, should it?
Edit:
Maybe in this case it's just the template of the LDAP plugin, that call's the wrong method to link to the documentation. I'll have another look into this.

@Faldon
Copy link
Contributor Author

@Faldon Faldon commented Mar 18, 2019

It seems, the LDAP plugin does not use any curious method but the buildDocLinkToKey function in the legacy/defaults file.
After the copyright year in footer is already made dynamic in master branch and dynamically resolving the current version is indeed the much better approach, I will close this PR later that day.

Copy link
Member

@rullzer rullzer left a comment

Fine for 15 IMO

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Fine with me 👍

@MorrisJobke MorrisJobke added this to the Nextcloud 15.0.6 milestone Mar 18, 2019
@MorrisJobke MorrisJobke merged commit da7579c into nextcloud:stable15 Mar 18, 2019
3 checks passed
@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Mar 18, 2019

/backport to master

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Mar 18, 2019

The backport to master failed. Please do this backport manually.

@Faldon Faldon deleted the update_document_version branch Mar 25, 2019
@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Mar 26, 2019

Fixed on master already

@rullzer rullzer mentioned this pull request Mar 29, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants