Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable15] Fix plural rule detection for languages #14867

Merged
merged 3 commits into from Mar 28, 2019

Conversation

Projects
None yet
5 participants
@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 26, 2019

Backport of #14628

15 didn't had any compiled assets for l10n.js, right?

nickvergessen and others added some commits Mar 11, 2019

Fix plural rule detection for languages
Signed-off-by: Joas Schilling <coding@schilljs.com>
Rename the variable aswell
Signed-off-by: Joas Schilling <coding@schilljs.com>
Fix behaviour of plural default rule
* undefined and empty string should trigger the default plural form

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

@rullzer rullzer force-pushed the backport/14628/stable15 branch from 917e2cb to 7b23324 Mar 27, 2019

@faily-bot

This comment has been minimized.

Copy link

faily-bot bot commented Mar 27, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17372: failure

TESTS=acceptance, TESTS-ACCEPTANCE=app-comments

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

@rullzer rullzer merged commit f4cc549 into stable15 Mar 28, 2019

1 check passed

continuous-integration/drone/pr the build was successful
Details

@rullzer rullzer deleted the backport/14628/stable15 branch Mar 28, 2019

@rullzer rullzer referenced this pull request Mar 29, 2019

Merged

15.0.6 RC 1 #14909

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.