Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiselect bar overlapping recommendations #15164

Merged
merged 3 commits into from Apr 23, 2019
Merged

Fix multiselect bar overlapping recommendations #15164

merged 3 commits into from Apr 23, 2019

Conversation

jancborchardt
Copy link
Member

Fix nextcloud/recommendations#29 please review @MorrisJobke @ChristophWurst @nextcloud/designers

Before:
multiselect before

After:
multiselect bar after

And even sticky when scrolling:
multiselect bar sticky

@jancborchardt
Fix multiselect bar overlapping recommendations
04591c3 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt jancborchardt added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: files labels Apr 18, 2019
@jancborchardt jancborchardt added this to the Nextcloud 16 milestone Apr 18, 2019
@jancborchardt jancborchardt mentioned this pull request Apr 18, 2019
Closed
skjnldsv
skjnldsv approved these changes Apr 18, 2019
View reviewed changes
apps/files/css/files.scss Outdated Show resolved Hide resolved
@jancborchardt jancborchardt mentioned this pull request Apr 18, 2019
Closed
@jancborchardt
Copy link
Member Author

Backport to stable16 at #15166 if needed.

@skjnldsv
Copy link
Member

Backport to stable16 at #15166 if needed.

you could have use the backport bot? :)

@jancborchardt
Copy link
Member Author

Backport to stable16 at #15166 if needed.

you could have use the backport bot? :)

Yeah, I remembered directly after I opened the backport 🤦‍♂️ :D What’s the syntax again? /backport stable16?

@skjnldsv
Copy link
Member

/backport to stable16

@MorrisJobke
Add webkit/safari fix
9b0c6d9 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
MorrisJobke approved these changes Apr 18, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 18, 2019
ChristophWurst
ChristophWurst approved these changes Apr 18, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

skjnldsv
skjnldsv previously requested changes Apr 18, 2019
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use @include position('sticky'); then. It will do it automatically :)

@jancborchardt
Use sticky position include for Safari support
83210d7 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@skjnldsv skjnldsv merged commit ca92a7c into master Apr 23, 2019
@skjnldsv skjnldsv deleted the recommendations-multiselect-overlap branch April 23, 2019 14:06
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 23, 2019
Merged
@backportbot-nextcloud
Copy link

backport to stable16 in #15198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv left review comments

@newhinton newhinton Awaiting requested review from newhinton

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: files
Projects
None yet
Milestone
Nextcloud 17
Development

Successfully merging this pull request may close these issues.

Multiselect table header overlays the recommendations
4 participants
@jancborchardt @skjnldsv @MorrisJobke @ChristophWurst