New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Fix folder drag glitch in Firefox #1528

Merged
merged 1 commit into from Sep 27, 2016

Conversation

Projects
None yet
4 participants
@MorrisJobke
Member

MorrisJobke commented Sep 26, 2016

issue:

  • drag'n'drop a folder into the files app in Firefox
  • the highlight stays there because Firefox doesn't trigger the drop event for folders

solution:

  • behave like the drop event if the dragover event isn't fired for 100ms (only applied in Firefox)
  • backport of #1406

@schiessle @nickvergessen @LukasReschke @MariusBluem @Henni Mind to test this?

Fix folder drag glitch in Firefox
issue:
* drag'n'drop a folder into the files app in Firefox
* the highlight stays there because Firefox doesn't trigger the drop event for folders

solution:
* behave like the drop event if the dragover event isn't fired for 100ms (only applied in Firefox)

@MorrisJobke MorrisJobke added this to the Nextcloud 10.0.2 milestone Sep 26, 2016

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Sep 26, 2016

@MorrisJobke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @vincchan, @butonic and @luckydonald to be potential reviewers

mention-bot commented Sep 26, 2016

@MorrisJobke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @vincchan, @butonic and @luckydonald to be potential reviewers

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke
Member

MorrisJobke commented Sep 26, 2016

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen
Member

nickvergessen commented Sep 27, 2016

👍

1 similar comment
@MariusBluem

This comment has been minimized.

Show comment
Hide comment
@MariusBluem
Member

MariusBluem commented Sep 27, 2016

👍

@MariusBluem MariusBluem merged commit cb2da78 into stable10 Sep 27, 2016

3 checks passed

Scrutinizer 1 new issues
Details
approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@MariusBluem MariusBluem deleted the stable10-backport-1406 branch Sep 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment