New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the max length for components #1543

Merged
merged 1 commit into from Sep 27, 2016

Conversation

Projects
None yet
4 participants
@nickvergessen
Member

nickvergessen commented Sep 27, 2016

Fix #1531

Going with 64, because all components we know appended comma-separated are 49

@MorrisJobke @LukasReschke

Increase the max length for components
Signed-off-by: Joas Schilling <coding@schilljs.com>
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Sep 27, 2016

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @schiessle, @LukasReschke and @BernhardPosselt to be potential reviewers

mention-bot commented Sep 27, 2016

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @schiessle, @LukasReschke and @BernhardPosselt to be potential reviewers

@LukasReschke

This comment has been minimized.

Show comment
Hide comment
@LukasReschke

LukasReschke Sep 27, 2016

Member

As discussed 👍

Member

LukasReschke commented Sep 27, 2016

As discussed 👍

@schiessle

This comment has been minimized.

Show comment
Hide comment
@schiessle

schiessle Sep 27, 2016

Member

👍

Member

schiessle commented Sep 27, 2016

👍

@schiessle schiessle merged commit 6ca8ce6 into master Sep 27, 2016

3 checks passed

Scrutinizer No new issues
Details
approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details

@schiessle schiessle deleted the increase-component-length branch Sep 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment