Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fetching additional search results on scrolling down #15557

Merged
merged 1 commit into from Sep 28, 2019

Conversation

rbuehlma
Copy link
Contributor

When searching for files, the first 30 results are listed. Currently it is not possible to fetch additional results. The code to fetch more results when scrolling down is already there but it seems the scrolling container has changed.
This fix re-enables this feature.

This also fixes #15088

Tested on Firefox and Nextcloud 16.0.0.

@kesselb kesselb added this to the Nextcloud 17 milestone May 16, 2019
@skjnldsv
Copy link
Member

/backport to stable16

@skjnldsv
Copy link
Member

Related? #15260

@rbuehlma
Copy link
Contributor Author

Related? #15260

Seems to be a different issue from my point of view.

Additionally, while my fix does work on a desktop browser, it does not work on my mobile browser. I'll try to figure out that as well.

@rbuehlma rbuehlma force-pushed the fix_search_result_fetch_more branch from 902b6f1 to bc2377f Compare May 17, 2019 10:41
@rbuehlma
Copy link
Contributor Author

It's now fixed for mobile browsers as well.

@MorrisJobke MorrisJobke mentioned this pull request Jul 15, 2019
28 tasks
@the-sane
Copy link

the-sane commented Aug 18, 2019

Will this fix grid view not scrolling to load in additional photos? #16510?

@rullzer rullzer mentioned this pull request Aug 18, 2019
@rbuehlma
Copy link
Contributor Author

Will this fix grid view not scrolling to load in additional photos? #16510?

No, unfortunately, it does not.

@rullzer rullzer mentioned this pull request Aug 23, 2019
@skjnldsv
Copy link
Member

@rbuehlma please rebase on latest master :)

@rbuehlma rbuehlma force-pushed the fix_search_result_fetch_more branch from bc2377f to f0391e1 Compare August 23, 2019 10:48
@rbuehlma
Copy link
Contributor Author

@rbuehlma please rebase on latest master :)

Rebase done but not tested after rebase.

@juliushaertl juliushaertl added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 26, 2019
@rullzer rullzer mentioned this pull request Aug 29, 2019
16 tasks
@rullzer rullzer modified the milestones: Nextcloud 17, Nextcloud 18 Sep 5, 2019
@rullzer
Copy link
Member

rullzer commented Sep 5, 2019

Master is no 18 development. If this needs to go into 17 please follow the normal backport procedures after merging.

Signed-off-by: René Bühlmann <rene@buehlmann.net>
@skjnldsv skjnldsv merged commit ad6d50a into nextcloud:master Sep 28, 2019
@welcome
Copy link

welcome bot commented Sep 28, 2019

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-dev on Freenode for a chat!

@backportbot-nextcloud
Copy link

backport to stable16 in #17304

@skjnldsv
Copy link
Member

/backport to stable17

@backportbot-nextcloud
Copy link

backport to stable17 in #17305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] More search results options
7 participants