Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the global DOMPurify #17130

Merged
merged 1 commit into from Sep 14, 2019
Merged

Conversation

@ChristophWurst
Copy link
Member

ChristophWurst commented Sep 13, 2019

Found at #17123.

We don't really use it globally anymore, so no reason to keep it exported.

$ rg dompurify -M 300 -t js
core/src/globals.js
78:import DOMPurify from 'dompurify'

settings/js/vue-5.js
1:[Omitted long line with 1 matches]

core/js/dist/main.js
338:[Omitted long line with 1 matches]

settings/src/components/appDetails.vue
103:import dompurify from 'dompurify'
193:			return dompurify.sanitize(
@ChristophWurst ChristophWurst added this to the Nextcloud 18 milestone Sep 13, 2019
@ChristophWurst ChristophWurst self-assigned this Sep 13, 2019
@ChristophWurst ChristophWurst added this to TO REVIEW (max 4 PRs) in Christoph's Tasks via automation Sep 13, 2019
@ChristophWurst ChristophWurst force-pushed the refactor/deprecate-global-dompurify branch from c5ca0e9 to 29afff5 Sep 13, 2019
core/src/globals.js Outdated Show resolved Hide resolved
@ChristophWurst ChristophWurst force-pushed the refactor/deprecate-global-dompurify branch from 29afff5 to e912a77 Sep 13, 2019
@blizzz
blizzz approved these changes Sep 14, 2019
Christoph's Tasks automation moved this from TO REVIEW (max 4 PRs) to TO INTEGRATE Sep 14, 2019
@blizzz

This comment has been minimized.

Copy link
Member

blizzz commented Sep 14, 2019

conflicts

@rullzer

This comment has been minimized.

Copy link
Member

rullzer commented Sep 14, 2019

/compile amend /

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@rullzer rullzer force-pushed the refactor/deprecate-global-dompurify branch from e912a77 to db7cd7d Sep 14, 2019
@rullzer rullzer merged commit 4cae5ae into master Sep 14, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/drone/pr Build is running
Details
DCO DCO
Details
fixupbot No fixup commits found. The commit history is clean 👍
Details
Christoph's Tasks automation moved this from TO INTEGRATE to DONE Sep 14, 2019
@rullzer rullzer deleted the refactor/deprecate-global-dompurify branch Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.