add and remove tags from multiple files at once

[rolandinus]

#10674
Adds an option to the actions when multiple files are selected.
The tags from all selected files are fetched and the tags which are common to all files will be preselected.
When Tags are deselected they will be removed from all selected files.
When new Tags are selected or created they will be added to all files

[kesselb]

Could you rebase the branch? Should fix the test failures.

[skjnldsv]

@danxuliu could you give a hand on tests here? :)

[skjnldsv]

The rebase doesn't seems right 🙈

[rolandinus]

There was some mess with the rebase, should be ok now

[skjnldsv]

ALL GREEN!!!! @nextcloud/javascript can you believe it :D

[skjnldsv]

Hey @rolandinus
Now that 18 is released, could you rebase your work to latest master please? :)

[rolandinus]

Hey @rolandinus
Now that 18 is released, could you rebase your work to latest master please? :)

I rebased it to newest master, but now I get again errors on some the tests (for server side parts which I did not touch at all) Last time they vanished after rebasing them to the newest master. But I pushed directly after rebasing. Can anyone give me information about why these errors occur and how i can avoid them?

[skjnldsv]

Can anyone give me information about why these errors occur and how i can avoid them?

They're coming from anbother issue introduced in master.
They don't seems to be related to your (awesome) work :)

[rullzer]

I rebased this for CI

[jancborchardt]

this legacy jquery style is more than just outdated. But that is the state of the files app right now, so I guess this is ok?

Yep – it is indeed outdated but that’s where we are. It’s good for 19 and a big help for people who use tagging.

Short of bigger design feedback I only have 1 point @rolandinus

• The "Tags" action should not be the last action in the menu. Better between "Download" and "Select file range". (The last action should always be the destructive action, in this case being "Delete".

[jancborchardt]

This block should go a bit further up so it’s below the "Download" action instead. :) Otherwise all good

[jancborchardt]

See comment ^

[skjnldsv]

Yep – it is indeed outdated but that’s where we are. It’s good for 19 and a big help for people who use tagging.

No, sorry, I have to block.
This is too sensitive. Sorry @rolandinus , this is some areas of the code where it alwyas blow up later on. I refuse to be the one that have to fix 3 legacy files that are unrelated for this to get in.
Beside, 19 is feature freeze, nothing like that gets in for now :)

[ChristophWurst]

Those who eagerly want this feature can just apply as as patch. You can download that from https://patch-diff.githubusercontent.com/raw/nextcloud/server/pull/18199.patch.

[MorrisJobke]

No, sorry, I have to block.
This is too sensitive. Sorry @rolandinus , this is some areas of the code where it alwyas blow up later on. I refuse to be the one that have to fix 3 legacy files that are unrelated for this to get in.
Beside, 19 is feature freeze, nothing like that gets in for now :)

@rolandinus Unfortunately I have to acknowledge this. We are already in beta 7 and it is a too high risk of breakage here. I will move it to the 20 milestone.

[rolandinus]

I know the code is outdated, I just tried to fit it in with the code of the rest of the files app. I am happy to refactor it for a future version of NC. However it would only make sense if the rest of the files app is refactored before I guess

[skjnldsv]

@rolandinus Also, I want to give you some explanation, because I think you deserve to have some.
Our files app code is very old. While we're doing a crazy amount of work to have a proper implementation of our features in our apps, this is the core of our project and unfortunately it is incredibly messy. This was written in a different time and to be fair, none of us understand the code architecture. This is patched everywhere, contains lots of jQuery code, etc etc.
This makes it very hard to do anything, because any little enhancement always end up in multiple unknown bugs that takes a few days to debug.

It is never worth it.
We have plans to upgrade the files app too, but those things takes time, as youc an imagine. Keep in mind, we really are all in your awesome feature, but I'm too cold feet and cautious to approve this. For me it's not worth the risk (and we can gamble, but it always blow up somewhere unexpected, alway :( )

Hope you can understand why it takes so long for this to get approved.
Thanks again for your work and interest! 🤗 🙇‍♀️

[TueTchen]

Thank you all for your efforts and your explanations!
In the meantime I'll help myself/ourselves by using the good old school tool 'nc-direct' (= SQL 😅). The tag relation are really very simple, and our acribic file naming help us to get a main mass tagging done on its lowest level.
Regarding our wider usage of tagging (currently >100 tags for >3000 files), there are also growing new requirement and wishes, that underline a well-thought refactoring - e.g. hierarchical tag relations, access rights enhancements and also another kind of showing and handling file taggings (we've already up to 20 tags for the single file, it's not really easy to identify missing or wrong tags).

So thank you again, always good luck & good speed and please stay healthy!
Peter

[skjnldsv]

Closing, see #18199 (comment)

[Sandro1955]

Hi, I installed version 12.01, but I can't find the "multiple tags" function in the actions. How do I go about implementing it?

[Sandro1955]

Hi, I installed version 21.0.4, but I can't find the "multiple tags" function in the actions. How do I go about implementing it?

[skjnldsv]

#28133 & #28135